Skip to content

Incorporating lumi counter and FSR creation into Sprucing workflow

Nicole Skidmore requested to merge lumicounting into master

Sprucing jobs (excl. and pass) need to count the number of events that have the lumi routing bit 94. This counter then needs to be written to an FSR for every stream such that a DaVinci tool can access it downstream.

Changes

  • 'input_process' with the type 'InputProcessTypes' has been promoted to Moore LbExec options (from DV) and takes over 'process'
  • Spruce (excl and pass) now take 'input_process=Hlt2' - this drives the excl job reco and writes the FSR
  • 'spruce_control_node' contains the 'lumi_node' with the event counter
  • Unit tests added for excl and pass that check all output DSTs have same and correct FSR inside

Needs LHCb!4064 (merged)

Desired unit tests

  • Lumi counter is correct on "known" file
  • Lumi counter is propagated correctly to FSR
  • Every stream ends up with the same FSR
  • Get rid of explicit write_fsr option in both yaml. Currently being evauated to None in write_fsr_default in options.py
  • Sort out docs in all 3 projects
  • Is DV still working?
  • The above but make sure that, even if no lines in the stream fire, the FSR is written to the output file

Work towards DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/26.

Edited by Nicole Skidmore

Merge request reports