Skip to content

Changing BPV to OWNPV for RD lines

Jamie Gooding requested to merge jnicolin/rd-btoxll-dev into rd-devel-march25

The following changes have been made to replace BPV functors with OWNPV functors, as per !2886 and #868.

  • remove unnecessary pvs = make_pvs()
  • BPV...(pvs) functors go to OWNPV...
  • MINIPCHI2CUT(cut, pvs) goes to OWNPVIPCHI2 >= cut

Other builders would need to be updated as well. The rate slightly increased from 17.0kHz to 17.25kHz. Following Wouters merge request !2886

Rate and BW numbers

Tests performed across 100k events

HLT2 BW

cutbased_inclusive_trigger: 31.3 MB (+/-0% from 31.3 MB) rd: 35 MB (+9.7% from 34 MB)

HLT2 rates

cutbased_inclusive_trigger: cbll_rates.md rd: rd_rates.md

To-do list:

  • Blanket replacement of BPV to OWNPV in RD builders
  • Blanket replacement of BPV to OWNPV in RD lines
  • Change to target rd-devel-march25 (!4491 (merged))
  • Follow-up on lines outside of RD (e.g., inclusive dilepton triggers) which rely on RD builders
    • Cut-based inclusive detached dilepton trigger lines (core changes in !4349 (merged), arguments renamed here)
    • MVA-based inclusive detached dilepton trigger lines (core changes in !4401 (merged), arguments renamed here)
  • Check for (and remove if necessary) calls of MINIPCHI2 and OWNPVIPCHI2 for photons/\pi^0
  • Check if reversion of MINIPCHI2-> OWNPVIPCHI2 in MVAs required (and implement)
    • baryonic_radiative_builders.py
    • rare_tau_decay_builders.py
    • b_to_xll_tmva_builder.py
    • b_tmva_builder.py already sorted in !4491 (merged)
  • Pick up latest changes from rd-devel-march25 and resolve conflicts
  • Estimate of rate and bandwidth
  • Move rdbuilder_thor back to Hlt2Conf ?

Requires !4292 (merged), lhcb-datapkg/ParamFiles!124 and LHCb!4728. Built on (but does not require) !4352 (closed).

Cc @mramospe @matzeni @wouter @mvesteri @msaur

Checking that updated modules run:

  • b_to_Xdilepton_detached
  • b_to_hemu
  • b_to_hemu_control_modes
  • b_to_kstarmumu
  • b_to_v0ll_hlt2
  • b_to_xll_hlt2
  • b_to_xll_hlt2_mva
  • b_to_xll_spruce
  • baryonic
  • btosetau_exclusive_hlt2
  • btosetau_tau_to_e_exclusive
  • btosmutau_exclusive_hlt2
  • btostautau_ee_exclusive_hlt2
  • btostautau_exclusive_hlt2
  • btostautau_exclusive_spruce
  • btostautau_mue_exclusive_htl2
  • prompt_multilepton
  • qqbar_to_ll
  • rad_incl
  • rare_tau_decay_lines
  • inclusive_detached_dilepton_trigger
  • All turbo
  • All full
  • All spruce
Edited by Fionn Caitlin Ros Bishop

Merge request reports

Loading