Update SMOG2 KS trackeff lines in Turcal

This MR aims to add some updates and improvements to the Ks->pipi tracking efficiency lines using the VELO-Long method with Ks candidates coming from SMOG2. They mostly follow what is already in the equivalent lines for pp (https://gitlab.cern.ch/lhcb/Moore/-/blob/master/Hlt/Hlt2Conf/python/Hlt2Conf/lines/trackeff/KSVeloLong.py?ref_type=heads).

To do:

• Add tis filter for HLT1 unbiasing
• Add selective persistency of matched track
• Remove RAW banks (not needed with selective persistency)
• Readjust selection to reduce background and improve kinematic converage, update prescales
• Unifiy code with KSVeloLong (with pp lines, following Sasha and Laurent suggestion)
• Remove Long track containers (keep only MatchedLongPions and MatchedUpstreamPions)
• Test new Bandwidht with SMOG2 data, compare with previous one (expect a reduction thanks to moving to Turbo strategy)
• Check if I need to change the line names, or if further changes are needed in hlt2/sprucing sequence

Local Bandwidth tests results (on a representative pp+pAr sample from Block 1, the same as in !4500 (merged) ). Note that this data is from block 1 (mu pp 4.4), so the SMOG2 bandwidth is representative while the bandwidth of pp lines should be below that one in mu=5.3 conditions.

Before any changes (baseline, as in master)

	Line	Total Retention (%)	Rate (kHz)	Exclusive Retention(%)	Exclusive Rate (kHz)	Avg Total Event Size (kB)	Total Bandwidth (GB/s)	Avg DstData Size (kB)	DstData Bandwidth (GB/s)
6	SpruceTurCalTrackEff_SMOG2KshortVeloLong_HighPTDecision	1.19	0.108	1.19	0.108	44.1	0.00476	1.84	0.000199
9	SpruceTurCalTrackEff_SMOG2KshortVeloLong_LowPTDecision	0.927	0.084	0.927	0.084	40.4	0.00339	2.42	0.000203
11	SpruceTurCalTrackEff_SMOG2KshortVeloLong_VeryHighPTDecision	0.662	0.06	0.662	0.06	51.9	0.00312	1.8	0.000108

 

	Line	Total Retention (%)	Rate (kHz)	Exclusive Retention(%)	Exclusive Rate (kHz)	Avg Total Event Size (kB)	Total Bandwidth (GB/s)	Avg DstData Size (kB)	DstData Bandwidth (GB/s)
0	Hlt2TurboVelo2Long_KshortHardDecision	0.03	0.36	0.03	0.36	52.4	0.0189	51.9	0.0187
1	Hlt2TurboVelo2Long_KshortVHardDecision	0.016	0.192	0.016	0.192	64.8	0.0124	64.3	0.0123
2	Hlt2TurboVelo2Long_KshortDecision	0.014	0.168	0.014	0.168	66	0.0111	65.6	0.011
3	Hlt2TurboVelo2Long_KshortSoftDecision	0.012	0.144	0.012	0.144	70.8	0.0102	70.3	0.0101
4	Hlt2TurboVelo2Long_KshortVSoftDecision	0.007	0.084	0.007	0.084	61.2	0.00514	60.8	0.00511

(note that here Long and Upstream containers were persisted, as changes from !4407 (merged) had not been merged by then)

As with the proposed changes

Hlt/Hlt2Conf/python/Hlt2Conf/lines/trackeff/KSVeloLong.py

@@ -61,6 +61,16 @@ hlt1_tis_lines = [
     "Hlt1SingleHighEtDecision",
 ]
 
+hlt1_tis_lines_smog2 = [
+    "Hlt1SMOG22BodyGenericDecision",
+    "Hlt1SMOG22BodyGenericPromptDecision",
+    "Hlt1SMOG2SingleTrackHighPtDecision",
+    "Hlt1SMOG2SingleTrackVeryHighPtDecision",
+    "Hlt1PassthroughPVinSMOG2Decision",
+    'Hlt1SMOG2BENoBiasDecision',
+    'Hlt1SMOG2etacToppDecision', 
+    'Hlt1SMOG2D2KpiDecision',
+]
 
 @configurable
 def filter_pions(particles, pvs=None, pt_min=0.4 * GeV):
@@ -92,11 +102,13 @@ def filter_particles_velo(particles, pvs):
 
 
 @configurable
-def filter_particles_tis_velo(particles, pvs):
+def filter_particles_tis_velo(particles, pvs, fromSMOG2=False):
     pre_filtered_particles = filter_particles_velo(particles, pvs)
 
+    if fromSMOG2: hlt1_filter_lines = hlt1_tis_lines + hlt1_tis_lines_smog2
+    else: hlt1_filter_lines = hlt1_tis_lines
     return hlt1_tis_on_any_filter(
-        hlt1_trigger_lines=hlt1_tis_lines,
+        hlt1_trigger_lines=hlt1_filter_lines,
         data=pre_filtered_particles,
         name="Hlt1TISFilter_Velo2Long_{hash}",
         advanced_tistos_arguments={
@@ -116,6 +128,7 @@ def make_kshort_pi_muplus_specific_charge(
     comb_m_min=0 * MeV,
     comb_m_max=2650 * MeV,
     comb_maxdoca=0.15 * mm,
+    fromSMOG2=False,
     name="KShortMuPiCombiner_{hash}",
 ):
     combination_code = F.require_all(
@@ -124,11 +137,17 @@ def make_kshort_pi_muplus_specific_charge(
     )
     vertex_code = F.require_all(
         F.END_VRHO < 100 * mm,
-        F.END_VZ > 18 * mm,
+        F.BPVFD(pvs) > 5 * mm
+        F.BPVVDRHO(pvs) > 3 * mm
         F.END_VZ < 600 * mm,
-        F.BPVFD(pvs) > 5 * mm,
-        F.BPVVDRHO(pvs) > 3 * mm,
     )
+    if fromSMOG2:
+        vertex_code &= F.END_VZ > -550 * mm
+        vertex_code &= bpv_in_smog2(make_pvs),
+    else: 
+        vertex_code &= F.END_VZ > 18 * mm
+        
+
     return ParticleCombiner(
         [pions, muons],
         name=name,
@@ -160,18 +179,20 @@ def construct_hlt2_line(
     p_min=5000.0,
     filter_tis=False,
     apply_lambda_veto=False,
+    fromSMOG2=False,
 ):
     pvs = make_pvs()
+
     pions = filter_pions(make_long_pions(), pvs, pt_min=0.5 * GeV)
     turbo_line = name.find("Hlt2Turbo") != -1
 
     if filter_tis:
-        muonsVelo = filter_particles_tis_velo(make_velo_muons(), pvs)
+        muonsVelo = filter_particles_tis_velo(make_velo_muons(), pvs, fromSMOG2)
     else:
         muonsVelo = filter_particles_velo(make_velo_muons(), pvs)
 
     kshorts = make_kshort_pi_muplus(
-        pions, muonsVelo, pvs=pvs, comb_m_max=1500, comb_m_min=0
+        pions, muonsVelo, pvs=pvs, comb_m_max=1500, comb_m_min=0, fromSMOG2=fromSMOG2,
     )  # probe should be on index 1
 
     filtered_kshorts = KSLongVeloFilter(
@@ -223,16 +244,18 @@ def construct_hlt2_line(
         ).OutputLocation
 
         particles_to_match = [
-            ("LongPions", make_long_pions()),
-            ("UpPions", make_up_pions()),
             ("MatchedLongPions", matched_long_pions),
             ("MatchedUpstreamPions", matched_upstream_pions),
         ]
     else:
         particles_to_match = None
+
+    algs_list = upfront_reconstruction() + [require_pvs(pvs), filtered_kshorts]
+    if fromSMOG2: algs_list = make_smog2_prefilters(pvs=make_pvs) + [filtered_kshorts]
+    
     return Hlt2Line(
         name=name,
-        algs=upfront_reconstruction() + [require_pvs(pvs), filtered_kshorts],
+        algs=algs_list,
         prescale=prescale,
         monitoring_variables=["m"],
         extra_outputs=particles_to_match,