Skip to content

Add switch to run selections on real-time reconstruction

Sascha Stahl requested to merge sstahl_full_hlt2 into master

Added switch to run selections from the reconstruction algorithms rather than the reconstruction stored on files.

An example script can be found in generic_example_with_reco.py.

Short summary

The following allows to change to prompt reconstruction.

reconstruction.global_bind(from_file=False)
run_moore(options, make_lines, public_tools)

or

with reconstruction.bind(from_file=False):
    run_moore(options, make_lines, public_tools)

Implementation

The implementation is done by adding an extra layer to RecoConf.

  • The file RecoConf.reco_objects_from_file defines reconstruction from file.
  • The file RecoConf.hlt2_global_reco defines the HLT2 reconstruction.
  • The file RecoConf.reconstruction_objects allows to switch between the two. This is the module which should be imported by selections. The switch is done via the function reconstruction and the argument from_file is configurable via bind to True or False.

Further cleanups

  • Added module RecoConf.global_tools as a more obvious place for configurations like stateProvider_with_simplified_geom.
  • Changed name of make_protoparticles to make_charged_protoparticles

Todo

  • Only the generic example is running, adapt HLT2 lines once implementation and names have been discussed.
  • All Hlt2 lines requires some further work to run without errors, see discussion in !541 (comment 3572315) .
  • The calo reconstruction needs PVs, which leads to a circular dependency of modules, implemented workaround for that, should be made nicer. Previously it was wrong as it was always taking PVs from file.

Closes #161 (closed)

Follow ups

  • Make PhotonMakerAlg and MergedPi0Maker and enable lines with neutrals #192 (closed)
  • Understand crashes in the lines Hlt2Run2Jets or discard the module in favor of the Run 3 one.
  • Make (charged)ProtoParticle sequence fully functional or change proto particle model, see #179 (closed)
Edited by Sascha Stahl

Merge request reports