Will HltEfficiencyChecker's "TOS" algorithm cause confusion w.r.t. old-school TOS moving forward?
Suggestion by @mengzhen - many thanks.
Our "TOS" algorithm in HltEfficencyChecker is different to the old-school "TOS" algorithm, and both algorithms will be in use in the future, albeit in different contexts. For example, the HltEfficiencyChecker TOS algorithm works "online" and matches the true signal to the trigger reconstructed candidate, whereas the "TISTOS" method matches "offline" and matches an offline reconstructed candidate to the trigger reconstructed candidate. I haven't done a thorough review of the "TISTOS" code, but there are likely to be slight implementation differences, even if the main idea of the algorithm is the same.
As @mengzhen pointed out, there is a danger this could cause quite a bit of confusion, particularly with newcomers to the software.
Should we rename the algorithm used in HltEfficiencyChecker?