Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • M MooreAnalysis
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 14
    • Issues 14
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • MooreAnalysis
  • Issues
  • #23
Closed
Open
Issue created Oct 12, 2021 by Ross John Hunter@rjhunterDeveloper

Will HltEfficiencyChecker's "TOS" algorithm cause confusion w.r.t. old-school TOS moving forward?

Suggestion by @mengzhen - many thanks.

Our "TOS" algorithm in HltEfficencyChecker is different to the old-school "TOS" algorithm, and both algorithms will be in use in the future, albeit in different contexts. For example, the HltEfficiencyChecker TOS algorithm works "online" and matches the true signal to the trigger reconstructed candidate, whereas the "TISTOS" method matches "offline" and matches an offline reconstructed candidate to the trigger reconstructed candidate. I haven't done a thorough review of the "TISTOS" code, but there are likely to be slight implementation differences, even if the main idea of the algorithm is the same.

As @mengzhen pointed out, there is a danger this could cause quite a bit of confusion, particularly with newcomers to the software.

Should we rename the algorithm used in HltEfficiencyChecker?

Edited Oct 12, 2021 by Ross John Hunter
Assignee
Assign to
Time tracking