Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • M MooreAnalysis
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCb
  • MooreAnalysis
  • Merge requests
  • !58

Add ability to chain HLT1 and HLT2 in 1 HltEfficiencyChecker job

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ross John Hunter requested to merge chain-hlt1-and-hlt2 into master Oct 21, 2021
  • Overview 36
  • Commits 30
  • Pipelines 16
  • Changes 26

FYI @rmatev @sstahl @mvesteri

This MR adds new functionality to HltEfficiencyChecker so that you'll be able to ask questions like

  • "What is the efficiency/rate of my HLT2 line given Hlt1XLine (and Hlt1YLine) and Z denominator?"
  • "What is the efficiency/rate of my HLT2 line given events passed the Z denominator and passed any HLT1 line?"

which has been requested by a few people recently.

TODO:

  • Build the user interface
  • Add a new test for this
  • Remove --level analysis arg from all examples after #12 (closed) was addressed.
  • Update the docs to explain the new features (Moore!1092 (merged))

Closes #24 (closed)

Also closes #12 (closed), as this became a problem for running the analysis scripts with both HLT1 and HLT2 branches in the tree, so I fixed it here.

Requires Moore!1092 (merged) for updated documentation.

Many thanks go to @mkenzie and @mmonk for helping to respectively build and test this.

Edited Nov 01, 2021 by Ross John Hunter
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: chain-hlt1-and-hlt2