Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • O Online
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Online
  • Merge requests
  • !351

smixx stack : fix clang build error due to incorrect usage of default parameter value

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christopher Rob Jones requested to merge jonrob/Online:smixx-fix-clang-errors into master Jan 06, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Address build errors with clang introduced when smixx was added. e.g.

https://lhcb-nightlies.web.cern.ch/logs/build/nightly/lhcb-master-mr/280/x86_64-centos7-clang8-opt/Online/

Online/smixx/src/translator/stack.cxx:19:18: error: addition of default argument on redeclaration makes this constructor a default constructor
Stack::Stack(int size = 1000) : _maxLen(size), _top(EMPTY)
                 ^      ~~~~
Online/smixx/src/translator/stack.hxx:16:2: note: previous declaration is here
        Stack(int size);
        ^
2 warnings and 1 error generated.

note there are a number of additional warnings with clang, not addressed here. A number look potentially concerning so probably worth investigating.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: smixx-fix-clang-errors