Minimal EventBuilding library

MooreOnline!70 (closed) needs a few headers from Online/EventBuilding. Unfortunately that package is not built in master. I've added some checks that test for a recent version of lhcb-daq40-software and for the presence of MPI. If either of these is not found, a minimal library is built that is sufficient for MooreOnline!70 (closed).

@mfrank I saw that cmake/PCIE40.cmake exists, but it seems to not be used anywhere anymore and is geared toward finding things in a build directory of lhcb-daq40-software. Should I integrate the searches and checks introduced here with PCIE40.cmake?

@flpisani I noticed that EventBuilding needs a development branch of lhcb-daq40-software, but pcie40_reader.cpp was not compatible with that branch. I've fixed that here.

assigned to @flpisani

added 2 commits

• 32d5a9f0 - Build minimal EventBuildingLib if either of pcie40 libraries or MPI are not found
• 4954d3df - Follow recent changes in lhcb-daq40-software

Compare with previous version

@raaij the modification you make to pcie40_reader.cpp doesn't match with the version of the library that is currently installed on the machines. The version you are referring to is Paolo's personal dev branch and it should not yet be used. You branch currently doesn't compile and/or run on any of the EB nodes.

In master P40_DAQ_STREAM::P40_DAQ_STREAM_ODIN0 is used in RU.cpp, which is also not available on the machines. Should that be changed instead?

The P40_DAQ_STREAM::P40_DAQ_STREAM_ODIN0 is not available because Paolo didn't released the updated headers on all the machines. In any case the FW, library and driver on sodin01 are the updated ones and they match the EB code, if you want to build the EB you can use that specific machine. If you change the code now the EB will be out of sync with the rest and it will not work anymore.

My purpose with these changes was to make it build correctly with the versions that are in use at the moment. I (wrongly) assumed that the change to the name of pcie40_hdr_frg_nometa would go together with the addition of P40_DAQ_STREAM::P40_DAQ_STREAM_ODIN0. If I remove the changes to pcie40_reader.cpp, would the MR then be acceptable?

If it compiles correctly in the different configurations (no MPI, no PCIe40, ecc.) yes.

added 3 commits

• 878b0184 - Fix for RPC
• 16a6d44b - Update CMakeLists.txt
• 8cc232b6 - Build minimal EventBuildingLib if either of pcie40 libraries or MPI are not found

Compare with previous version

/ci-test --merge

Started integration test build. Once done, check the results or the comparison to a reference build.

I've dropped the commit, let's see what a ci-test does

added ci-test-triggered label

• [2021-11-30 17:15] Validation started with lhcb-master-mr#3230
• [2021-12-01 12:30] Validation started with lhcb-master-mr#3235

added 1 commit

• 79d81ccb - Fix some compiler warnings in MEP_tools

Compare with previous version

added 2 commits

• ac2bd88d - Fix some compiler warnings in MEP_tools and MFP_tools
• 8dd2043a - Allow building without sourceid.h from lhcb-daq40-software

Compare with previous version

sourceid.h from lhcb-daq40-software was still required, fixed that in `raw_tools.{hpp,cpp}.

/ci-test --merge

Started integration test build. Once done, check the results or the comparison to a reference build.

Throughput Test Moore_hlt2_reco_baseline: 173.3 Events/s -- change of -0.05% vs. reference

Throughput Test Moore_hlt2_fastest_reco: 431.3 Events/s -- change of 0.01% vs. reference

Throughput Test Moore_hlt2_pp_thor: 342.4 Events/s -- change of 0.30% vs. reference

Throughput Test Moore_hlt1_pp_default: 27660.9 Events/s -- change of -0.18% vs. reference

added 10 commits

• 8dd2043a...c724d0e0 - 7 commits from branch master
• 35455ad6 - Build minimal EventBuildingLib if either of pcie40 libraries or MPI are not found
• aa7baeee - Fix some compiler warnings in MEP_tools and MFP_tools
• acccb468 - Allow building without sourceid.h from lhcb-daq40-software

Compare with previous version

added 1 commit

• 26b7c5a8 - Fix more compiler warnings

Compare with previous version

marked this merge request as ready

I've fixed the remaining compiler warnings and tested that everything builds properly on sodin01.