Substitutions in DTFDict
Implementation of Substitutions in DTFDict, taken from the TupleToolDecayTreeFitter.
Merge request reports
Activity
55 60 declareProperty 56 61 ( "constrainToOriginVertex",m_usePV, 57 62 "flag to switch on PV contraint"); 63 64 declareProperty( "Substitutions", m_map, 65 "PID-substitutions : { ' decay-component' : 'new-pid' }" ) ; changed this line in version 2 of the diff
Have you discussed this addition with @sneubert? Adding him for information and feedback. Do you have any test for this, which would make sense to add to the nightlies suite? My other comment is about the branch. It would make sense to have this in the 2018-patches branch and then propagated to master. You committed to master, though.
- [2018-02-12 15:58] Validation started with lhcb-gaudi-head#1765
- [2018-02-13 00:12] Validation started with lhcb-gaudi-head-py3#63
- [2018-02-13 00:16] Validation started with lhcb-clang-test#860
- [2018-02-13 00:19] Validation started with lhcb-gaudi-head#1766
- [2018-02-13 00:20] Validation started with lhcb-head#1755
- [2018-02-13 00:20] Validation started with lhcb-tdr-test#58
- [2018-02-13 09:25] Validation started with lhcb-gaudi-head#1767
Edited by Software for LHCb@erodrigu : Unfortunately I don't have any test to be added to the nightlies right now, I've only produced some ntuples to test the feature. But I can have a look how to implement a test, if required.
About the branch: sure, I could apply the MR to the 2018-patches. However there's no opportunity to change branch on the fly anymore, as far I can see. Should I close and reopen the MR on that branch?
Hi @apiucci, having a test would be great. It's so much better to have tested code ;-). We are far from perfect so it would make sense to work better when adding code. You could also work with @sneubert to make sure the test tests the full algo, actually.Typically we get code to the 2018-patches and I then cherry-pick to master. This is very clean. If you can easily commit this same thing to 2018-patches then thanks. You would then close this one.
Hi @erodrigu , sure there's no problem. I've written a simple test that I will commit to the next MR pointing to the 2018-patches branch. Do we have already a test sample that we can use to test the algos?
mentioned in merge request !253 (merged)