make MomentumCombiner threadsafe

make MomemtumCombiner thread-safe: remove mutable member data, replace with local variable

added bug label

added bug fix label and removed bug label

mentioned in merge request Moore!589 (merged)

added 1 commit

• f0b8f392 - make MomentumCombiner threadsafe

Compare with previous version

added 1 commit

• 3b656349 - make MomentumCombiner threadsafe

Compare with previous version

approved this merge request

assigned to @acasaisv

/ci-test --merge

Started reference and integration test builds. Once done, check the comparison of build and test results.

added ci-test-triggered label

• [2020-12-04 12:00] Validation started with lhcb-master-mr#1694
• [2020-12-04 12:09] Validation started with lhcb-master-mr#1696
• [2020-12-09 16:36] Validation started with lhcb-master-mr#1718
• [2020-12-10 18:20] Validation started with lhcb-head-2#110

mentioned in issue Moore#231 (closed)

assigned to @lpica and unassigned @acasaisv

@acasaisv @sponce MR does not add any error in the nightlies if I'm not wrong, do you think this is ready for merging?

Is that not the one with a syntax error making the Moore tail fail ? I mean it goes with Moore!589 (merged), doesn't it ? Byt hte way it should be mentioned in the description.

Not sure anymore they are linked actually. But they were tested together. Where do you see a succesfull test of this one ?

I thought that the two were tested together, but unrelated and I don't see any error in Phys

@lpica I believe we should retest this one. Now let's wait a few hours that the queue goes

/ci-test --merge

Started reference and integration test builds. Once done, check the comparison of build and test results.

Throughput Test Moore_hlt2_reco_baseline: 142.8 Events/s -- change of -0.09% vs. reference

Throughput Test Moore_hlt1_pp_default: 29856.4 Events/s -- change of 0.01% vs. reference

added lhcb-head-2 label

mentioned in commit 8cd8b9bb