prefer copy constructor over LHCb::State::clone

Gerhard Ravenrequested to merge
do-not-use-state-clone into master

LHCb::State is a concrete, final class, from which one cannot derive, so there is no reason for clone().

as a side effect, fix two memory leaks in ParameterizedKalman/src/CompareTracks.cpp

Edited by Marco Cattaneo

Merge request reports