Skip to content
Snippets Groups Projects

Improve IMeasurementProvider interface

Merged Gerhard Raven requested to merge improve-measurementproviderinterface into master
  • remove 'measurement' call which forces, for each measurement, a seperate lookup in the event store, followed by a (linear!) search in the cluster/hit container for the corresponding hit/cluster
  • update users of the IMeasurementProvider interface
  • update implementations of the IMeasurementProvider interface, reducing the number of lookups to one per type of hit per track (unfortunately, the linear search inside the hit/cluster container is still there for the time being)
Edited by Marco Cattaneo

Merge request reports

Pipeline #646123 passed

Pipeline passed for 39855ccf on improve-measurementproviderinterface

Merged by Marco CattaneoMarco Cattaneo 5 years ago (Jan 2, 2019 8:35pm UTC)

Loading

Pipeline #647286 passed

Pipeline passed for f00dbe67 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Gerhard Raven added 1 commit

    added 1 commit

    • 511f8272 - add maybe_view to streamline the use of `addMeasurements`

    Compare with previous version

  • Gerhard Raven resolved all discussions

    resolved all discussions

  • Gerhard Raven added 1 commit

    added 1 commit

    • 7ac8cac0 - add maybe_view to streamline the use of `addMeasurements`

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 1915d120 - add maybe_view to streamline the use of `addMeasurements`

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 2dcfdcee - add maybe_view to streamline the use of `addMeasurements`

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 6e4ed9e1 - add maybe_view to streamline the use of `addMeasurements`

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 33f2e5c7 - add maybe_view to streamline the use of `addMeasurements`

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 4c81846d - convert all measurements in one call

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • b3caaca2 - convert all measurements in one call

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 13bbb9e4 - convert all measurements in one call

    Compare with previous version

  • Gerhard Raven added 3 commits

    added 3 commits

    • 452bf884 - change ICaloFutureClusterTool,ICaloFutureSubClusterTag, and ICaloFutureHypoTool…
    • 3e538dc9 - Improve IMeasurementProvider interface
    • 548a74f3 - Convert measurements in batches, add view::single to simplify calling `addMeasurements`

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • e7ef55bc - Convert measurements in batches, add view::single, view::maybe

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • f044ae68 - Convert measurements in batches, add view::single

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 220a8442 - Convert measurements in batches, add view::single

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 9d9e8f6c - rename view::single into range::single

    Compare with previous version

  • Sascha Stahl
  • Just for my understanding of the global picture : do we plan to use this code in the future ? Certainly not in HLT1 after the improvements of Peter, but I wonder why we should not use the same approach in HLT2.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading