Skip to content

Avoid ubsan errors in ParameterizedKalmanFit due to excessively large data members

Christopher Rob Jones requested to merge ParameterizedKalmanFit-AvoidUBSanError into master

Fixes undefined behaviour errors like

/workspace/build/REC/REC_HEAD/Tr/ParameterizedKalman/src/ParameterizedKalmanFit.h:58:7: runtime error: member call on address 0x7f7a6d57b620 which does not point to an object of type 'extend_interfaces'
0x7f7a6d57b620: note: object has a possibly invalid vptr: abs(offset to top) too big
 7a 7f 00 00  90 9d 4e 70 7a 7f 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              possibly invalid vptr
    #0 0x7f7a703258f4 in ParameterizedKalmanFit::~ParameterizedKalmanFit() /workspace/build/REC/REC_HEAD/Tr/ParameterizedKalman/src/ParameterizedKalmanFit.h:58
    #1 0x7f7a70326d04 in ParameterizedKalmanFit::~ParameterizedKalmanFit() /workspace/build/REC/REC_HEAD/Tr/ParameterizedKalman/src/ParameterizedKalmanFit.h:58

https://lhcb-nightlies.cern.ch/logs/tests/nightly/lhcb-sanitizers/96/x86_64-centos7-gcc8-dbg+ubsan/Brunel/

FYI @sstemmle @graven

Merge request reports