Skip to content

bugfixes to PrimaryVertexChecker

Florian Reiss requested to merge freiss_pvchecker_fix into master

this should fix two little bugs in the PrimaryVertexChecker (@adudziak):

  • number of close and isolated MC PVs now add up to the total number of MC PVs
  • don't skip anymore events where no PVs are reconstructed

PVChecker output before (tested with 1000 Upgrade minbias events):

PVChecker            INFO  ============================================
PVChecker            INFO  Efficiencies for reconstructible MC vertices: 
PVChecker            INFO  ============================================
PVChecker            INFO  
PVChecker            INFO  MC PV is reconstructible if at least 4  tracks are reconstructed
PVChecker            INFO  MC PV is isolated if dz to closest reconstructible MC PV >  10 mm
PVChecker            INFO  REC and MC vertices matched:  by dz distance
PVChecker            INFO  
PVChecker            INFO All                  :   0.919 (    4807 /     5231 )
PVChecker            INFO Isolated             :   0.678 (    2687 /     3962 )
PVChecker            INFO Close                :   0.622 (    2120 /     3407 )
PVChecker            INFO False rate           :   0.006 (      27 /     4834 )
PVChecker            INFO 
PVChecker            INFO L0 accepted PV of B  :   0.000 (       0 /        0 )
PVChecker            INFO False PV as B        :   0.000 (       0 /        0 )
PVChecker            INFO 
PVChecker            INFO       --------------------------------------------
PVChecker            INFO            Substatistics: 
PVChecker            INFO       --------------------------------------------
PVChecker            INFO       1st PV (highest multiplicity): 
PVChecker            INFO All                  :   0.995 (     984 /      989 )
PVChecker            INFO Isolated             :   1.000 (     581 /      581 )
PVChecker            INFO Close                :   0.988 (     403 /      408 )
PVChecker            INFO       ---------------------------------------
PVChecker            INFO       2nd PV: 
PVChecker            INFO All                  :   0.943 (     932 /      988 )
PVChecker            INFO Isolated             :   0.944 (     560 /      593 )
PVChecker            INFO Close                :   0.942 (     372 /      395 )
PVChecker            INFO       ---------------------------------------
PVChecker            INFO       3rd PV: 
PVChecker            INFO All                  :   0.884 (     857 /      969 )
PVChecker            INFO Isolated             :   0.865 (     482 /      557 )
PVChecker            INFO Close                :   0.910 (     375 /      412 )
PVChecker            INFO  
PVChecker            INFO       ---------------------------------------
PVChecker            INFO dx:    mean =  -0.000 +/- 0.000, RMS =  0.017 +/- 0.000
PVChecker            INFO dy:    mean =  -0.000 +/- 0.000, RMS =  0.016 +/- 0.000
PVChecker            INFO dz:    mean =  0.003 +/- 0.002, RMS =  0.103 +/- 0.002
PVChecker            INFO       ---------------------------------------
PVChecker            INFO pullx: mean =  -0.021 +/- 0.016, RMS =  1.099 +/- 0.013
PVChecker            INFO pully: mean =  0.009 +/- 0.016, RMS =  1.086 +/- 0.013
PVChecker            INFO pullz: mean =  0.020 +/- 0.016, RMS =  1.140 +/- 0.014
PVChecker            INFO  ============================================

now:

PVChecker            INFO  ============================================
PVChecker            INFO  Efficiencies for reconstructible MC vertices: 
PVChecker            INFO  ============================================
PVChecker            INFO  
PVChecker            INFO  MC PV is reconstructible if at least 4  tracks are reconstructed
PVChecker            INFO  MC PV is isolated if dz to closest reconstructible MC PV >  10 mm
PVChecker            INFO  REC and MC vertices matched:  by dz distance
PVChecker            INFO  
PVChecker            INFO All                  :   0.913 (    4807 /     5266 )
PVChecker            INFO Isolated             :   0.956 (    2687 /     2810 )
PVChecker            INFO Close                :   0.863 (    2120 /     2456 )
PVChecker            INFO False rate           :   0.006 (      27 /     4834 )
PVChecker            INFO 
PVChecker            INFO L0 accepted PV of B  :   0.000 (       0 /        0 )
PVChecker            INFO False PV as B        :   0.000 (       0 /        0 )
PVChecker            INFO 
PVChecker            INFO       --------------------------------------------
PVChecker            INFO            Substatistics: 
PVChecker            INFO       --------------------------------------------
PVChecker            INFO       1st PV (highest multiplicity): 
PVChecker            INFO All                  :   0.984 (     984 /     1000 )
PVChecker            INFO Isolated             :   0.983 (     581 /      591 )
PVChecker            INFO Close                :   0.985 (     403 /      409 )
PVChecker            INFO       ---------------------------------------
PVChecker            INFO       2nd PV: 
PVChecker            INFO All                  :   0.934 (     932 /      998 )
PVChecker            INFO Isolated             :   0.932 (     560 /      601 )
PVChecker            INFO Close                :   0.937 (     372 /      397 )
PVChecker            INFO       ---------------------------------------
PVChecker            INFO       3rd PV: 
PVChecker            INFO All                  :   0.877 (     857 /      977 )
PVChecker            INFO Isolated             :   0.859 (     482 /      561 )
PVChecker            INFO Close                :   0.901 (     375 /      416 )
PVChecker            INFO  
PVChecker            INFO       ---------------------------------------
PVChecker            INFO dx:    mean =  -0.000 +/- 0.000, RMS =  0.017 +/- 0.000
PVChecker            INFO dy:    mean =  -0.000 +/- 0.000, RMS =  0.016 +/- 0.000
PVChecker            INFO dz:    mean =  0.003 +/- 0.002, RMS =  0.103 +/- 0.002
PVChecker            INFO       ---------------------------------------
PVChecker            INFO pullx: mean =  -0.021 +/- 0.016, RMS =  1.099 +/- 0.013
PVChecker            INFO pully: mean =  0.009 +/- 0.016, RMS =  1.086 +/- 0.013
PVChecker            INFO pullz: mean =  0.020 +/- 0.016, RMS =  1.140 +/- 0.014
PVChecker            INFO  ============================================
Edited by Marco Cattaneo

Merge request reports