Skip to content

Modernize PatVeloTT

Gerhard Raven requested to merge modernize-patvelott into master
  • remove redundant destructors, initalize and finalize methods
  • flag local data classes as 'final', remove virtual destructors (which inhibits automated move constructors, assignment, so without them there is no need for explicit versions = default of those)
  • replace lookup table which is in every single PatVTTTrack by use of 'popcount'
  • prefer emplace_back over push_back
  • prefer STL algortihms over raw loops
  • reduce scope of local variables as much as possible
  • reserve vectors with reasonable defaults if possible
  • prefer removing 'in situ' over copying selected items followed by assignment to the original
  • make PatVeloTT::matchingTracks linear instead of quadratic in the number of hits

Merge request reports

Loading