Make Track{Kisel,HeraB}Extrapolator thread safe
- remove unneccesary mutable data member
- amalgamate header into component source
Merge request reports
Activity
added thread-safety label
added 1 commit
- 6a75069c - Make Track{HeraB,Kisel}Extrapolator thread safe
added 1 commit
- 4e6c8a4c - Make Track{HeraB,Kisel}Extrapolator thread safe
added 1 commit
- d6163bc5 - Make Track{HeraB,Kisel}Extrapolator thread safe
added 1 commit
- 72f3f87b - Make Track{HeraB,Kisel}Extrapolator thread safe
assigned to @mstahl
- Resolved by Rosen Matev
/ci-test
- Resolved by Gerhard Raven
I do not see
TrackKiselExtrapolator
being used anywhere and, due to that, it is untested. Why not remove it?
mentioned in issue Moore#148 (closed)
- [2020-03-31 10:23] Validation started with lhcb-master-mr#613
- [2020-04-07 00:11] Validation started with lhcb-gaudi-head#2572
- [2020-04-08 01:24] Validation started with lhcb-gaudi-head#2573
- [2020-04-09 00:14] Validation started with lhcb-gaudi-head#2574
- [2020-04-10 00:16] Validation started with lhcb-gaudi-head#2575
- [2020-04-11 00:12] Validation started with lhcb-gaudi-head#2576
Edited by Software for LHCbadded Tracking enhancement labels
- Resolved by Rosen Matev
@jonrob can you please review?
p.s. it would be much easier if the amalgamation was a separate commit
assigned to @jonrob
changes look fine to me on a scan through, although of course without any tests exercising these extrapolators its difficult to be sure nothing has changed in the results they give. If they are useful as 'reference' extrapolators, then I think adding some tests to use them, just for this sort of scenario, would be a good idea.