Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 232
    • Issues 232
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 61
    • Merge requests 61
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCb
  • Rec
  • Merge requests
  • !2140

Implement 2D measurements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jacco Andreas De Vries requested to merge track-fit-workshop-jadevrie into master Jul 16, 2020
  • Overview 333
  • Commits 1
  • Pipelines 89
  • Changes 24

Implementation of 2D measurements (for VP), rather than performing 2x 1D projection and filter steps for measurements that are actually of the form (X,Y). Saves filter/projection/minimise calls, extrapolation calls and aids in outlier removal.

Measurement type VP2D is added, logic is redone for N-dimensions, and a std::variant member of FitNode takes care of all dimension-dependent properties and calls.

The corresponding math is implemented in the LHCb math kernel in this MR: LHCb!2660 (merged)

2D measurements can be turned on by setting VPMeasurementProvider::Use2D = True as is done in the test here: Moore!983 (merged)

Connected downstream MRs: Moore!983 (merged), Alignment!208 (merged), Panoramix!115 (merged)

Reference updates: Moore!1340 (merged) Alignment!234 (merged) Brunel!1198 (closed)

Wishlist:

  • understand reason for minus sign in projectionmatrix for Y.
  • investigate 2D measurements for Muons as well (not just VP)
  • alignmentDerivatives for 2D measurements (in TrackTools/MeasurementProviderProjector)

Follow-up issue here: #211

Edited Feb 16, 2022 by Rosen Matev
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: track-fit-workshop-jadevrie