Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 290
    • Issues 290
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 67
    • Merge requests 67
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !216

Modernize PrMCTools

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gerhard Raven requested to merge modernize-prmctools into master Sep 18, 2016
  • Overview 6
  • Commits 3
  • Pipelines 0
  • Changes 4
  • do not explicilty implement functions the compiler will generate implicitly
  • do not keep variables with a lifetime scope of an event as members
  • prefer std::unique_ptr over raw pointer and delete
  • default arguments should be specified in declaration, not definition
  • prefer override over virtual
  • do not keep constants as member variable, but as static const in an anonymous namepsace
  • prefer range-based for loops
  • prefer for loop over while
  • prefer getIfExists over exists/get combo
  • do not check for duplicates while inserting (which is quadratic) but use sort / unique (which is logarithmic)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: modernize-prmctools