Skip to content

Cleanup TrackEventFitter and TrackBestTrackCreator

Christoph Hasse requested to merge TrackFitter_SpringCleaning into master

I noticed that the TrackEventFitter and TrackBestTrackCreator still had a lot of extra code that was originally implemented for the TrackVectorFitter.

We however don't need that code anymore and don't test that code path either.
Additionally, all the dead code makes it harder to understand the code we do execute and use.

So this MR tries to clean up a little in those files. No test changes expected.

I would have really liked to rename the ITrackFitter interface methods to something more meaningfull like fitTrack and fitTrackRange instead of having the IMHO very ugly ->operator()(...) way of calling the ITrackFitter interface.
The grownup in me says that a simple name change isn't worth introducing a lot of changes across multiple projects.... But then again... ->operator()(...) 🤢

Edited by Christoph Hasse

Merge request reports