Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 280
    • Issues 280
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 50
    • Merge requests 50
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !2406

use fast, approximate functions for overlap/correction algo speed increase

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Maarten Van Veghel requested to merge mveghel-fastcorrections-dev into master Apr 18, 2021
  • Overview 40
  • Commits 4
  • Pipelines 3
  • Changes 6

The majority of the time of the calo reco is now spent on shower overlap and correction calculations.

This MR introduces very fast approximations of exp, log, sqrt for corrections speedup from LHCb::Math::Approx. Will increase speed of overlap/correction algorithms with 20-30%.

In addition, all these calculations should be done with floats, not doubles as is now, as the precision needed is smaller than floating-point precision. Note: in the CondDB the parameters for these corrections are stored as doubles, but will be converted during initialization in the correction algos now.

Edited May 06, 2021 by Maarten Van Veghel
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mveghel-fastcorrections-dev