Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 289
    • Issues 289
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 64
    • Merge requests 64
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !252

Modernize Muon

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gerhard Raven requested to merge modernize-muon into master Oct 12, 2016
  • Overview 10
  • Commits 3
  • Pipelines 0
  • Changes 43
  • change memory layout: use vectors of values instead of vectors of pointers to values allocated on the heap. Carefully reserve all vectors to insure that the addresses of the values are stable.
  • add const when possible
  • prefer struct over class for interfaces with only public methods
  • prefer DeclareInterfaceID
  • remove obsolete SVN keywords
  • when returning 'owning pointers' do so using std::unique_ptr
  • add final
  • MuonLogHit: replace vector of either one or two pointers with std::pair
  • prefer implicit destructors
  • prefer STL algorithms over raw loops
  • prefer auto
  • minimize scope of variables
  • in 'factory functions' return the created object instead of using an OUT parameter and returning a StatusCode
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: modernize-muon