Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 282
    • Issues 282
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 48
    • Merge requests 48
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !2570

Fix XYZ functions in ThOr and fix functor testing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mengzhen Wang requested to merge fix_F_XYZ into master Sep 29, 2021
  • Overview 53
  • Commits 8
  • Pipelines 13
  • Changes 13

Closes Moore#323 (closed) .

This MR is to be reviewed, ci-tested and merged together with Moore!1031 (merged).

The matching table at https://lhcbdoc.web.cern.ch/lhcbdoc/moore/master/selection/thor_functors.html#functor-translation-table seems to be wrong. The existing F.X, F.Y and F.Z are not designed for vertices but tracks.

This MR defines a new F.VX(Y,Z, Rho) in Composite.h.

Also update BPVVDRHO and BPVVDZ. Not use composite.position(), but Sel::Utils::endVertexPos( composite ) to get the position info. This allows an additional check of whether the object is a legacy particle.

Edited Oct 19, 2021 by Rosen Matev
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_F_XYZ