Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 280
    • Issues 280
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 50
    • Merge requests 50
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !2587

fix: avoid alloacting huge objects on stack

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christoph Hasse requested to merge chasse_smaller_stack into master Oct 14, 2021
  • Overview 8
  • Commits 1
  • Pipelines 4
  • Changes 3

This MR makes a few small changed to avoid allocating huge objects on the stack to reduce total stack size.

Motivation was the use of perf to profile HLT2.
perf record --call-graph dward,<stack-size> only lets you specify a max stack-size of 64kB. If the stack is larger than that, perf won't be able to properly unroll the call-chain 😢

But on top this also seems to be better for performance, so it's a win-win 💵 💵 🎉

Edited Oct 15, 2021 by Christoph Hasse
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: chasse_smaller_stack