Migrates CaloMoniDst to Functional
This MR migrated all class in the Calo/CaloMoniDst
package to the new Gaudi::Functional
.
List of non-trivial changes
- There was a base class
CaloNtpBase
which intended to be a base class for other ntuple algo (according to thedoc/release.notes
). However, upon inspection, there were only 4 classes eligible, and only one of them is subclassingCaloNtpBase
. Those 4 classes does not seem to be similar enough to warrant a base class, and the C++11 syntaxes andGaudi::functional::Consumer
removes LOTS of boilerplate codes already, so the base classCaloNtpBase
is removed and those 4 classes now inherit directly fromConsumer
. - The need to keep the same configurable keys,
Input
andInputs
, is also taken into the consideration during the refactoring. Most of the classes adjust these 2 fields at the configuration-time (such thatInput
usually refers to a single relation table, whilstInputs
to possibily-many list of TES containers). The keys thus retain the same name when subclassing fromConsumer
, and for consistency the aliasing (using
) statement also do the same of readability. - New file
CaloMoniUtils
was added to provide common utility functions, instead of the statefulCaloNtpBase
.
The rest of the changes are c++11 modernisation to the code, a la Gerhard's style.