Skip to content
Snippets Groups Projects

PrFTZoneHandler - Check array bounds before access

Merged Christopher Rob Jones requested to merge jonrob/Rec:PrZone-add-array-bounds-checks into master
All threads resolved!

No index checking was applied before accessing the zone array.

In dd4hep builds this actually leads to out-of-bounds access due to some issues with the zone ID being larger than I presume was expected.

This will lead to exceptions being thrown in the dd4hep builds until that numbering is fixed, but this should be viewed as an improvement over out of bounds writing to random memory locations…

@lohenry FYI

Edited by Christopher Rob Jones

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading