Fix layerID method in FT DD4HEP by using layerIdx

See #382 (@jonrob @gligorov )

Should fix properly the "layer starting from 4" issue.

For note, an even more proper fix would overhaul how IDs are inconsistent between DetDesc and DD4HEP, and how DetDesc IDs are inconsistent between themselves (some are indices, some are local, some are global, from what I see). I do not think this is warranted for now.

Should be merged with Detector!263 (merged)

assigned to @lohenry

mentioned in merge request Detector!263 (merged)

changed the description

@lohenry thanks for this!

Will

"For note, an even more proper fix would overhaul how IDs are inconsistent between DetDesc and DD4HEP, and how DetDesc IDs are inconsistent between themselves (some are indices, some are local, some are global, from what I see). I do not think this is warranted for now."

lead to different results when running with DetDesc vs DD4HEP on the same MC sample, even if there are no "bugs"?

added dd4hep lhcb-dd4hep labels

Just to note this MR (if it works ;)) superceeds !3053 (closed)

added RTA label

/ci-test Detector!263 (merged)

added ci-test-triggered label

• [2022-08-02 14:09] Validation started with lhcb-master-mr#5297
• [2022-08-03 00:05] Validation started with lhcb-dd4hep-rootunits#7
• [2022-08-03 00:05] Validation started with lhcb-dd4hep#1220

@jonrob diffs seem ok to me, can you check if it solves your issue?

mentioned in merge request !3053 (closed)

resolved all threads

merged

mentioned in commit 43705842

mentioned in issue Moore#465 (closed)