Skip to content
Snippets Groups Projects

Add new algorithm and a functor for storing Hlt1 TIS/TOS information

Merged Abhijit Mathad requested to merge AM_Hlt1TisTos into master

The MR adds the following:

  • Add Hlt1TisTos algorithm (based on the old tool IParicleTisTos)
  • Two new functors:
    • F.VALUE: Functor to get a value from std::optional, if it encounters std::nullopt it throws a GaudiException.
    • F.MAP_TO_RELATED: Functor to store TIS/TOS information of user-specified Hlt1 lines using relations table.
  • Changes the functor grammer so that one can pass a dict to F.VALUE_OR(<dict>).
  • We also add tests for both F.VALUE and F.VALUE_OR(<dict>).

This MR only addresses Hlt1 Tis/Tos information. The Hlt2 Tis/TOS needs to be separate MR

Relates to https://gitlab.cern.ch/lhcb-dpa/project/-/issues/142.

To be tested with: LHCb!3845 (merged) DaVinci!771 (merged) Analysis!935 (merged)

FYI: @erodrigu , @pkoppenb , @yingl , @emarinov

Edited by Abhijit Mathad

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added RTA label

  • Abhijit Mathad changed the description

    changed the description

  • removed RTA label

  • Abhijit Mathad marked this merge request as draft

    marked this merge request as draft

  • added RTA label

  • Sascha Stahl
  • Sascha Stahl
  • Sascha Stahl
  • How would one use the functor in a trigger line? E.g. the Topo will probably cut on something like the TOS of Hlt1(Two)?TrackMVA.*Decision. Would there be another functor which looks this up in the output map of the functor implemented here?

  • Sascha Stahl
  • Sascha Stahl
    • Resolved by Abhijit Mathad

      Thanks for the MR @amathad .

      Need to correctly set the location of Hlt1 DecReport and SelReport (@nskidmor input is needed here).

      The locations seem hard coded. Do we guarantee stability of the locations? In the end these are locations which should come out of a decoder which is functional and can be configured via PyConf.

      Hlt2 Tis/TOS (@graven : Should this be a separate MR?)

      I think HLT2 TisTos can be a separate MR.

      Need to add test in DaVinci (Hope @oozcelik can help me here). Not sure how to go about adding test in Rec.

      See other questions, what about using the functor in lines? There we also need to be able to use TISTOS. Should this be done via functors or via a dedicated algorithm?

  • Sascha Stahl
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading