Add new algorithm and a functor for storing Hlt1 TIS/TOS information
The MR adds the following:
- Add
Hlt1TisTos
algorithm (based on the old toolIParicleTisTos
) - Two new functors:
-
F.VALUE
: Functor to get a value fromstd::optional
, if it encountersstd::nullopt
it throws aGaudiException
. -
F.MAP_TO_RELATED
: Functor to store TIS/TOS information of user-specified Hlt1 lines using relations table.
-
- Changes the functor grammer so that one can pass a
dict
toF.VALUE_OR(<dict>)
. - We also add tests for both
F.VALUE
andF.VALUE_OR(<dict>)
.
This MR only addresses Hlt1 Tis/Tos information. The Hlt2 Tis/TOS needs to be separate MR
Relates to https://gitlab.cern.ch/lhcb-dpa/project/-/issues/142.
To be tested with: LHCb!3845 (merged) DaVinci!771 (merged) Analysis!935 (merged)
Merge request reports
Activity
assigned to @amathad
- Resolved by Abhijit Mathad
- Resolved by Abhijit Mathad
- Resolved by Abhijit Mathad
added RTA label
removed RTA label
added RTA label
- Resolved by Abhijit Mathad
Very nice to see this @amathad
What is the motivation for storing a dedicated TOB value? TOB is equivalent to (NOT TIS AND NOT TOS) so this doesn't add extra information.
- Resolved by Sascha Stahl
- Resolved by Abhijit Mathad
- Resolved by Abhijit Mathad
- Resolved by Abhijit Mathad
- Resolved by Abhijit Mathad
- Resolved by Abhijit Mathad
Thanks for the MR @amathad .
Need to correctly set the location of Hlt1 DecReport and SelReport (@nskidmor input is needed here).
The locations seem hard coded. Do we guarantee stability of the locations? In the end these are locations which should come out of a decoder which is functional and can be configured via PyConf.
Hlt2 Tis/TOS (@graven : Should this be a separate MR?)
I think HLT2 TisTos can be a separate MR.
Need to add test in DaVinci (Hope @oozcelik can help me here). Not sure how to go about adding test in Rec.
See other questions, what about using the functor in lines? There we also need to be able to use TISTOS. Should this be done via functors or via a dedicated algorithm?
- Resolved by Abhijit Mathad