Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 282
    • Issues 282
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 48
    • Merge requests 48
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !3147

PrForwardTracking correct check for empty hits container

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andre Gunther requested to merge gunther_fthits_fix_size_check into master Oct 12, 2022
  • Overview 13
  • Commits 1
  • Pipelines 2
  • Changes 1

The previous check for emptiness had no effect because technically the hit container is never really empty because of sentinels and padding. This is fixed by using the newly added empty function from the hit container.

Goes with LHCb!3814 (merged)

Edited Oct 12, 2022 by Andre Gunther
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gunther_fthits_fix_size_check