Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 282
    • Issues 282
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 48
    • Merge requests 48
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !3206

fix calo index bookkeeping

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Maarten Van Veghel requested to merge mveghel-caloindexfix into master Nov 22, 2022
  • Overview 53
  • Commits 5
  • Pipelines 6
  • Changes 15

Fix bookkeeping of cluster/hypo indices in charged pid algos and downstream. In addition, improves consistency in variable naming (and code comments).

Essentially, only saves CaloCellID (with .all() the unsigned int representation) and not anymore the internal cluster index. For RelationTables etc, only the SOACollection index is used where appropriate for consistency, as RelationTables only accept SOACollections now (not anymore the inter cluster index).

In addition, some related cleanup / simplifying.

Related MRs: LHCb!3884 (merged), Moore!1901 (merged), DaVinci!802 (merged)

Related issue(s): #357 (closed)

Edited Dec 03, 2022 by Maarten Van Veghel
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mveghel-caloindexfix