Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 289
    • Issues 289
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 64
    • Merge requests 64
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !352

Adapt to the new re-entrant TransportSvc calls

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christopher Rob Jones requested to merge UseReentrantTransportSvcCalls into master Nov 11, 2016
  • Overview 4
  • Commits 5
  • Pipelines 0
  • Changes 16

Adapts to LHCb!422 (merged)

In the Rich, the tool in question is never going to be used in a threaded application (I have something different in RichFuture) so I just create the cache once and save it, in a non thread safe way, as effectively what was happening before inside the TransportSvc.

DetailedMaterialLocator needs to be made thread safe though. For the moment I have done this in a non optimal way, by just creating the cache before each call.

      auto cache = m_transportSvc->createCache(); // Need a better solution
      rc = m_transportSvc->intersections_r( start, vect, mintick, maxtick, intersepts, 
                                            cache, m_minRadThickness, m_geometry);

But this needs to be handled better. I think though that can only be correctly done by pushing the creating and handling of the cache further up the call stack.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: UseReentrantTransportSvcCalls