Skip to content

Fixed VeloTrackMonitor to work with online tracks and moderinzed code in VeloRecMonitors

David Hutchcroft requested to merge FixAndModerizeVeloTrackMonitor into master

Fixed VeloTrackMonitor so that the 2nd metal layer effects monitoring histograms are produced in the BrunelOnline environment (uses lite not full clusters in fits)

Also modernized and fixed coverity warnings in VeloTrackMonitor, VeloExpertClusterMonitor, VeloIPResolutionMonitor, VeloIPResolutionMonitorNT, VeloOccupancyMonitor and VeloSamplingMonitor:

  • Removed empty destructor
  • Simplified constructors
  • Used auto
  • Removed unused variables
  • Better array initialisation
  • Used C++11 lambdas rather than boost lambda and bind.
  • Remove m_binary and replace with LHCb::Math::sqrt_12
  • Initialise all pointers in class to nullptr explicitly
  • Removed $Id: lines from headers
  • Removed WIN32 #pragmas
  • Removed commented out subroutines

Also fixed PVResolution

  • Several issues with column types in tuples
  • Increased track size array from 100 to 500 (was running out of space every tenth event in 2015 data used in tests)
  • Many optimisations (copying tracks twice just to count number of left/right was not ideal)

In VeloOccupancyMontior fixed coverity error about Time of check/Time of use when doing mkdir (now one operation)

Merge request reports