Skip to content

Check SciFi channel x-ordering doesn't change when applying calibration

Izaac Sanderswood requested to merge isanders-valid-scifi-calib into 2024-patches

Requires Detector!605 (merged)

This is to make sure that the (existing) mat-end calibration values can't change the channel x-ordering. What I have done is to take the position calculation from PrStoreSciFiHits, but looping over every SiPM and channel in each mat to make sure that x_i-1 < x_i.

The idea is that the calibration values for a given mat are overwritten with 0s in the cache if x is not always increasing moving from one channel to the next.

To-do:

  • Check sign and channel numbering are valid
  • Check calculations still make sense without cluster info
  • How to add some warning messages if not monotonically increasing
  • Does it need a corresponding version in Allen?
Edited by Christopher Rob Jones

Merge request reports