Skip to content

Fix SHARE_BPV functor to not compare addresses of two pointers

Matthew Scott Rudolph requested to merge fix-share-bpv into 2024-patches

A bug fix to get correct output from the SHARE_BPV functor. It was using ADDRESSOF on each BPV, but ADDRESSOF did not check if the input was already a pointer. So equality was always failing. After discussion with @graven on Mattermost (wp3 channel), attacking the problem from two directions:

  • Remove use of ADDRESSOF in SHARE_BPV since it is unnecessary
  • Add check in AddressOf C++ code to check if its inputs are already pointers, since the user likely wants to know if the objects pointed to are the same.

No additional test at this time, but it would be desirable (please advise).

Merge request reports