Skip to content

Future fix velo performance

Renato Quagliani requested to merge future-fixVeloPerformance into future

  1. Make uses of the sorting in zip:view from @raaij

  2. bug-fix for storing contributing pixels to cluster. While looping through multiple Pixels to form a Clusters the vector is stored internally to a vector<vector > where the size will be the final amount of clusters. Fill was done with .push_back( { { Pixel } } ) at any iteration while the logic from "master" branch was storing the pixels for the current created cluster. So only at the first iteration you would actually needed to create a vector with the current Pixel , while in next loops you just need to fill the vector created before.

It should give back the standard velo performance (rather than 0% and 100% ghost rate) performance ( nightly - cross check is the Velo PrChecker2 output, since the PrForward is affected by a bug on the modPrHit when flagging on tracks).

From local checks performances match the master branch output.

Can work in tandem with Lbcom!116 (diffs) where the VPClusterLinker is converted to Functional as Consumer

Merge request reports