Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 289
    • Issues 289
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 61
    • Merge requests 61
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !623

ProtoParticle Moni : Fix the conversion of the track type enum to string

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christopher Rob Jones requested to merge ProtoMoni-FixTrackTypeToStringConv-2017 into 2017-patches Jun 16, 2017
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Due to changes in the 2017 stack in how the track type enum to string conversion is handle, a small regression in the ProtoParticle monitoring occurred. It previously used

const auto type = std::to-string( track->type() ) + "/";

to construct the hist paths. This previously worked fine, giving paths like Long/. Now, its giving an exact representation of the enum as a number 1/ etc.

This MR fixes this by using instead

const auto type = LHCb::Track::TypesToString( track->type() ) + "/";

@adinolfi This bug is currently affecting the ProtoParticle plots in the prompt DQ. These will be fixed by this patch, once it is deployed and you update to use it.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ProtoMoni-FixTrackTypeToStringConv-2017