Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 289
    • Issues 289
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 63
    • Merge requests 63
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !717

Modernize Muons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gerhard Raven requested to merge modernize-muon into master Aug 18, 2017
  • Overview 23
  • Commits 6
  • Pipelines 0
  • Changes 16
  • make interfaces inherit from extend_interfaces, and use DeclareInterfaceID
  • avoid trailing return types in interfaces
  • deprecate interface methods which take a string as argument, provide method which takes an enum instead -- this avoids having to create a string, and then parse it, on every call
  • prefer inheriting constructors
  • prefer std::abs over fabs
  • prefer std::transform over std::for_each
  • add const
  • move debug printout out of loop
  • simplify logic
  • prefer std::array over std::vector to avoid heap allocation
  • prefer passing std::array<>& over decayed pointers
  • prefer true/false over 1/0 assignments for bool
  • prefer std::array.fill over loops
  • simplify inside using lambda
  • prefer range-based for loops
  • prefer switch/case over if-else-if-else-if-
  • prefer boost::static_vector over std::vector if there is a known upperlimit on the maximum size
  • prefer range-based loop over BOOST_FOREACH
Edited Dec 18, 2017 by Marco Cattaneo
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: modernize-muon