Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 289
    • Issues 289
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 63
    • Merge requests 63
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !847

Use addSortedForwardStates when inserting new states on TrackEventFitter

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Monir Hadji requested to merge mhadji-specific-addtostates into master Jan 15, 2018
  • Overview 13
  • Commits 2
  • Pipelines 0
  • Changes 2

propagate and need LHCb!1060 (merged)

not really much faster, just a bit faster in the hlt1 case, states are always already sorted when we are on this function

we call this function only on TrackMasterFitter.cpp:1042

but we have a sort on states just before TrackMasterFitter.cpp:1005

maybe the probability to have 100% of sorted states as input is not true outside hlt1, that's why a specific function as suggested by @sponce

it's not a critical part but maybe still better to avoid duplication of process, difference between these 2 functions is around ~14% according to callgrind

Edited Jan 29, 2018 by Marco Cattaneo
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mhadji-specific-addtostates