Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 289
    • Issues 289
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 63
    • Merge requests 63
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !927

Fix in-place modification of PrPixelTracking property

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Olli Lupton requested to merge olupton_prpixel_property into master Feb 22, 2018
  • Overview 12
  • Commits 2
  • Pipelines 0
  • Changes 2

Don't update m_maxScatter in-place. This makes running Moore from a TCK that contains PrPixelTracking give consistent results to running from settings.

Without this fix then running from TCK gave different results, as the original parameter value was squared twice when running from a TCK.

cc: @rmatev @chasse @hschindl

See also: gaudi/Gaudi#16

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: olupton_prpixel_property