Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 289
    • Issues 289
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 61
    • Merge requests 61
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !937

Improvements on PrStoreUTHit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Monir Hadji requested to merge mhadji-change-utsort into master Feb 26, 2018
  • Overview 60
  • Commits 5
  • Pipelines 0
  • Changes 5

This MR needs LHCb!1163 (merged)

id is a unique number to identify couple station/layer

current algo : sort (using rv3) ut hits by id first then by x at y=0

here we have swaps on 2 vectors :

  • the id vector of MultiIndexedHitContainer
  • the hits vector of MultiIndexedHitContainer

as input we have already hits sorted by id

  • Remove this sort and replace by a stable sort on x for the 4 layers;
  • Also use a constant time getter to get sectors of UT

gain around ~55% on PrStoreUTHit according to callgrind

before; after

utimprove

recbefore.cg recafter.cg

@sponce

Edited Mar 29, 2018 by Marco Cattaneo
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mhadji-change-utsort