Review outcome of Py3 migration
Now that futurize
has been ran in futurize_cleanup_Urania10
, the last step is to review the changes. This is the last effort, thanks everyone for the help, we are really close to the end!
The following actions are required to be done ASAP, please open MRs targeting futurize_cleanup_Urania10
:
futurize
(@kheinick @dhill @poluekt):
Review changes from - Stage 1: !314 (c0045602)
- Stage 2: !314 (05b21819)
Please check the changes are correct (Dònal and Anton, please review PIDCalib, TrackCalib and Meerkat; Kevin, please review B2DXFitters). You can run if needed a test, but most changes are purely trivial and can be reviewed in ~1 hour. A comment from @clemenci:
Changes like
from builtins import str
andfrom builtins import object
are dangerous, and I had to drop many of them in the rest of the software stack;from builtins import range
is often useless. I suggest to carefully review the changes.
If the builtins changes is useless, please remove it. Just do a grep -r 'builtins' *
in your folder to spot the changes.
@kheinick):
Fix problems in two python files (These two files need to be fixed in order to run futurize
on them. I will do so after the fixes are done:
RefactoringTool: Can't parse PhysFit/B2DXFitters/data/Bs2DsK_Run2CPV/Bs2DsPi/BiasedSFit/BiasedDMSFit.py: ParseError: bad input: type=26, value='{', context=(' ', (7, 9))
RefactoringTool: Can't parse PhysFit/B2DXFitters/data/Bs2DsK_Run2CPV/Bs2DsPi/BiasedSFit/MDFit.py: ParseError: bad input: type=26, value='{', context=(' ', (6, 9))