A collection MR of minor tweaks that I notice while developing but are out-of-scope
Changes
generate:migrate minor error code bug
!35 (919f3d9a)
The value for ret was defined in the wrong scope and therefore error codes risked being calculated incorreclty.
Remove redundant tck_id variable from hackily_change_dataPackages_cmd
- added minor docstring explaining
workflow_and_settings comparisons were somewhat clunky and duplicated
Slimmed down now
Prevent typos or comparison to hard-coded strings by defining stack-based and commit-based workflow variables once
No need to define subparser and then lambda to it -> Just define it within appropriate scope initially
Large changes to use a class for Workflow(enum) and Specification
This reduces a lot of hard-coded tck_spec['parameters']['label'] etc, now it's defined once and only once, and all accessing of these variables henceforth are much nicer.
spec = helper.yaml_parser(yaml_fp)
tck_id = hex(spec['ID'])
tck_commits = spec['parameters']['commits']
...
# ->
spec = Spec(yaml_fp)
tck_id = spec.id
tck_commits = spec.commits
...
ToDo
-
Verify if this is necessary anymore hackily_change_dataPackages
. POSTPONED TO : #17 (closed)
Edited by Luke Grazette
Merge request reports
Activity
Filter activity
assigned to @lugrazet
added Development label
added 1 commit
- 86d48fbf - hackily_change_dataPackages doens't use variable tck_id
- Resolved by Luke Grazette
Do we even need
hackily_change_dataPackages
once !34 (merged) goes in?
added 1 commit
- f3a9b76a - Remove some code duplication in workflow_and_settings:
- Resolved by Luke Grazette
We might want to replace the implicit navigation of the dictionaries with instead a class we instantiate.
That way columns are well defined once and typos are become less common
added 6 commits
-
46b22a00...fdcb2ab5 - 2 commits from branch
main
- e4165785 - Minor scoping issue of ret, error code wouldn't be correctly accumulated
- 72709f72 - hackily_change_dataPackages doens't use variable tck_id
- 1e76addd - Remove some code duplication in workflow_and_settings:
- 6a4fb1de - only hard-code '{stack,commit}-based' once
Toggle commit list-
46b22a00...fdcb2ab5 - 2 commits from branch
mentioned in issue #13 (closed)
added 6 commits
-
6a4fb1de...96d56f01 - 2 commits from branch
main
- f41b9b98 - Minor scoping issue of ret, error code wouldn't be correctly accumulated
- b99dcb12 - hackily_change_dataPackages doens't use variable tck_id
- e970f0fd - Remove some code duplication in workflow_and_settings:
- 689b1d0e - only hard-code '{stack,commit}-based' once
Toggle commit list-
6a4fb1de...96d56f01 - 2 commits from branch
added 1 commit
- 8c6ec3b9 - Typo, exactly why I'm moving to using these classes
Please register or sign in to reply