A collection MR of minor tweaks that I notice while developing but are out-of-scope

Changes

generate:migrate minor error code bug

!35 (919f3d9a)
The value for ret was defined in the wrong scope and therefore error codes risked being calculated incorreclty.

Remove redundant tck_id variable from hackily_change_dataPackages_cmd

!35 (fefb3e59)

• added minor docstring explaining

workflow_and_settings comparisons were somewhat clunky and duplicated

!35 (b08e2bc2)

Slimmed down now

Prevent typos or comparison to hard-coded strings by defining stack-based and commit-based workflow variables once

!35 (46b22a00)

No need to define subparser and then lambda to it -> Just define it within appropriate scope initially

!35 (40b88c76)

Large changes to use a class for Workflow(enum) and Specification

!35 (8b514816)

This reduces a lot of hard-coded tck_spec['parameters']['label'] etc, now it's defined once and only once, and all accessing of these variables henceforth are much nicer.

spec = helper.yaml_parser(yaml_fp)
tck_id = hex(spec['ID'])
tck_commits = spec['parameters']['commits']
...
# ->
spec = Spec(yaml_fp)
tck_id = spec.id
tck_commits = spec.commits
...

ToDo

• Verify if this is necessary anymore hackily_change_dataPackages. POSTPONED TO : #17 (closed)

ci-test/stages/check.py

@@ -60,67 +60,6 @@ def id(specs: list[str], tck_tags: list[str]):
     return 0
 
 
-def prconfig_version(tags: list[str], specs: list[str]):
-    """
-        Checks that the prconfig is the latest version, flags if not, per tck.
-    """
-    ret = 0
-    messages = []
-    __log = lambda msg: helper.log_friendly_message(messages=messages, msg=msg)
-    ref_yaml_fp = specs[0]
-    ref_tck_spec = helper.yaml_parser(ref_yaml_fp)
-    ref_tck_tag = ref_tck_spec['parameters']['PRConfig']
-
-    if ref_tck_tag not in tags:
-        __log(
-            f"ERROR: PRConfig tag {ref_tck_tag} is not a valid relase. Check configuration"
-        )
-        ret += 1
-
-    decomposed_tck_tag = helper.decompose_tag(ref_tck_tag)
-    print(f"decomposed_tck_tag: {decomposed_tck_tag}")
-
-    decomposed_tags = {tag: helper.decompose_tag(tag) for tag in tags}
-    print(f"decomposed_tags:\n{decomposed_tags}")
-    latest_v = sorted([decomp[0] for decomp in decomposed_tags.values()],
-                      reverse=True)[0]
-    latest_r = sorted([
-        decomp[1]
-        for decomp in decomposed_tags.values() if decomp[0] == (latest_v)
-    ],
-                      reverse=True)[0]
-    latest_p = sorted([
-        decomp[2] for decomp in decomposed_tags.values()
-        if (decomp[0] == latest_v and decomp[1] == latest_r)
-    ],
-                      reverse=False)[0]
-
-    decomposed_latest_tag = (latest_v, latest_r, latest_p)
-    print(f"decomposed_latest_tag: {decomposed_latest_tag}")
-    latest_tag = f"v{latest_v}r{latest_r}p{latest_p}" if latest_p > 0 else f"v{latest_v}r{latest_r}"
-    if decomposed_tck_tag != decomposed_latest_tag:
-        __log(
-            f"WARNING: PRConfig tag {ref_tck_tag} is not the latest version {latest_tag}. Are you sure?"
-        )
-        ret += 1
-    else:
-        __log(f"PRConfig tag {ref_tck_tag} is the latest version.")
-
-    # repeat the printing at the bottom of the log for ease of reading.
-    print("\nSTARTING SUMMARY OF JOB")
-    print("------------------------------------------------------------------")
-    for msg in messages:
-        print(msg)
-    print("------------------------------------------------------------------")
-    if ret != 0:
-        raise RuntimeError(
-            f"WARNING:: Some PRConfig tags are not most recent version {ret}. Check logs.\n"
-        )
-    else:
-        print("SUCCESS:: PRC tag check completed successfully.")
-    print("FINISHED SUMMARY OF JOB\n")
-
-
 def workflow_and_settings(specs: list[str]):
     """
         Checks the following for every specification:
@@ -149,8 +88,7 @@ def workflow_and_settings(specs: list[str]):
                     isParameter=isParameter,
                     log=__log)
 
-            for key, isParameter in zip(['stack', 'PRConfig', 'workflow'],
-                                        [True, True, False]):
+            for key, isParameter in zip(['stack', 'workflow'], [True, False]):
                 ret += __compare(key=key, isParameter=isParameter)
 
             if ref_tck_spec['workflow'] == helper.COMMIT_BASED_WORKFLOW:
@@ -158,7 +96,7 @@ def workflow_and_settings(specs: list[str]):
 
     if ret > 0:
         raise RuntimeError(
-            "FAILURE::TCK specifications within a single MR need to share the same project Stack/Workflow/Commits/PRConfig_version. Check configuration"
+            "FAILURE::TCK specifications within a single MR need to share the same project Stack/Workflow/Commits. Check configuration"
         )
 
     # Now that we know they share the same configuration, we only need to do this for the first specification.