Code review with pep8 changes
Please look at FIXME
Replace all references to any PATH by a global var as I did for the first two functions Remove function from main
Fix all remaining pylint errors :
************* Module locmap
W:149, 0: FIXME not_a_module = modules.remove('site.pp') (fixme)
W:229, 0: FIXME why do we use the protected member _module_name of a client class ? (fixme)
W:293, 0: FIXME parser is too generic, choose a better variable name (fixme)
W:313, 0: FIXME results is too generic, choose a better variable name (fixme)
R: 20, 0: Too many local variables (20/15) (too-many-locals)
W: 83, 8: Redefining name 'parser' from outer scope (line 294) (redefined-outer-name)
C:123,16: Invalid variable name "LOG_FILENAME" (invalid-name)
C:125,16: Invalid variable name "LOG_FILENAME" (invalid-name)
W:231, 7: Access to a protected member _module_name of a client class (protected-access)
W:232,11: Access to a protected member _module_name of a client class (protected-access)
W:234,55: Access to a protected member _module_name of a client class (protected-access)
W:235,30: Access to a protected member _module_name of a client class (protected-access)
W:237,19: Access to a protected member _module_name of a client class (protected-access)
W:238,55: Access to a protected member _module_name of a client class (protected-access)
W:239,30: Access to a protected member _module_name of a client class (protected-access)
W:243,24: Access to a protected member _module_name of a client class (protected-access)
R: 20, 0: Too many branches (61/12) (too-many-branches)
R: 20, 0: Too many statements (116/50) (too-many-statements)
C:294, 4: Invalid constant name "parser" (invalid-name)
C:314, 4: Invalid constant name "results" (invalid-name)
It would be good to have this fixed before the end of the day tomorrow.
You will need to run pylint on the modules too and fix all issues.