Tech dependency for pytimber
Created by: fsoubelet
This is the implementation PR for https://github.com/pylhc/omc3/issues/272
Checklist:
-
Check that CI workflows install fine. -
Document the caveat. -
Failsafe the imports of pytimber
functionality inomc3
(currently only inomc3.tune_analysis.timber_extract.py
, which is only imported inomc3.amplitude_detuning_analysis.py
). -
Specify source="nxcals"
when declaringdb = pytimber.LoggingDB()
, since the change fromCALS
toNXCALS
has been made.
I took the opportunity to remove unsused parts of setup.py
and do a little bit of type hinting in omc3.tune_analysis.timber_extract.py
.
I also named the extra tech
to stay consistent with the naming adopted in PyLHC
.