Skip to content

Tech dependency for pytimber

Michael Hofer requested to merge tn_dependencies into master

Created by: fsoubelet

This is the implementation PR for https://github.com/pylhc/omc3/issues/272

Checklist:

  • Check that CI workflows install fine.
  • Document the caveat.
  • Failsafe the imports of pytimber functionality in omc3 (currently only in omc3.tune_analysis.timber_extract.py, which is only imported in omc3.amplitude_detuning_analysis.py).
  • Specify source="nxcals" when declaring db = pytimber.LoggingDB(), since the change from CALS to NXCALS has been made.

I took the opportunity to remove unsused parts of setup.py and do a little bit of type hinting in omc3.tune_analysis.timber_extract.py.

I also named the extra tech to stay consistent with the naming adopted in PyLHC.

Merge request reports