Slim down fluentbit-metrics deployment if not installed by the user

Description

There's two bits that are currently configured and deployed that do not respect the value of .Values.metrics.fluentbit.enabled.

Motivation

It removes a warning in the Prometheus logs and it prevents a "void" Kubernetes service from being deployed.

Potential Impact

I don't think there's any impact.

Merge Request Checklist

  • Documentation has been updated, if applicable.
  • Changes have been tested locally using helm install . ....
[~/d/m/h/kubernetes-monitoring]@outstanding
λ helm secrets template . -f values.yaml -f ../../kubernetes-base-monitoring-chart-values/values.yaml -f ../../kubernetes-base-monitoring-chart-values/secrets.yaml -f ../../kubernetes-base-monitoring-chart-values/monit-gp-qa.yaml -s templates/prometheus/prometheus.yaml | kubeconform -schema-location '/home/nacho/dev/CRDs-catalog/{{.Group}}/{{.ResourceKind}}_{{.ResourceAPIVersion}}.json' --verbose
[helm-secrets] Removed: ../../kubernetes-base-monitoring-chart-values/secrets.yaml.dec
stdin - Prometheus it-monit-metrics-collector-prometheus is valid
[~/d/m/h/kubernetes-monitoring]@outstanding
λ helm secrets template . -f values.yaml -f ../../kubernetes-base-monitoring-chart-values/values.yaml -f ../../kubernetes-base-monitoring-chart-values/secrets.yaml -f ../../kubernetes-base-monitoring-chart-values/monit-gp-qa.yaml -s templates/prometheus/prometheus.yaml 
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/nacho/k8s/argocd/embargo-test/config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/nacho/k8s/argocd/embargo-test/config
[helm-secrets] Decrypt: ../../kubernetes-base-monitoring-chart-values/secrets.yaml
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/nacho/k8s/argocd/embargo-test/config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/nacho/k8s/argocd/embargo-test/config
---
# Source: cern-it-monitoring-kubernetes/templates/prometheus/prometheus.yaml
apiVersion: monitoring.coreos.com/v1
kind: Prometheus
[...]
  remoteWrite:
    - url: https://monit-prom-mom.cern.ch:9090/api/v1/write
      tlsConfig:
        insecureSkipVerify: true
      basicAuth:
        username:
          name: it-monit-metrics-collector-prometheus
          key: username
        password:
          name: it-monit-metrics-collector-prometheus
          key: password

[helm-secrets] Removed: ../../kubernetes-base-monitoring-chart-values/secrets.yaml.dec

Note no push to it-monit-metrics-fluentbit:8080 configured.

Additional Notes

Edited by Nacho Barrientos

Merge request reports

Loading