Node-API proper GC
Job #37784003 failed :
It seems we enabled experimental features of Node.js and some changes they introduced reveals some miss-conception.
The change (and eventual fix) are there: https://github.com/nodejs/node/commit/7a216d5fd6331c98c117ef471d0c971c8d97f757#diff-e0c9c14097c971aa0d2a3259a13543543b1b14c9752f5dea08ed2c8d1407aff8
Issue makes sense, we modify the js context in a GC callback which makes things recursive for their GC (and probably way harder to maintain), so they decided to make env const
to prevent user from playing with js in such callbacks (having to call node_api_post_finalizer
which we run in proper js context).
Modification we have to do is probably to call node_api_post_finalizer
in AccessPoint::Destructor
.
I also think we should turn off experimental features (for the main build) and eventually dedicate a CI branch to experimental things.