Christos Anastopoulos authored 2 years ago and Edward Moyse committed 2 years ago

partially revert MR57649. Due to ATLASRECTS-7336

Christos Anastopoulos authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

ATLASRECTS-7326: rm TrackSlimmer alg. Simplify the SlimmingTool

Christos Anastopoulos authored 2 years ago and Frank Winklmeier committed 2 years ago

Track Collection Merger: use ConstDataVector for VIEW container with correct semantics. The const_cast is needed due to summaries

Track Collection Merger: use ConstDataVector for VIEW container with correct semantics. The const_cast is needed actually because we create/update summaries

Christos Anastopoulos authored 2 years ago and Frank Winklmeier committed 2 years ago

rm seemingly unused SimpleTrackCollectionMerger

Move private header files to `src/` and cleanup cmake configuration.

It is a widespread and reasonable, but incorrect, pattern to assume that if a handle(key) is not used then it should not be initialized.
In fact, this leaves the data dependency active in the scheduler, and no error will be thrown if the handle is never accessed.
Instead, the handle should be initialized(false) - this MR makes the change

Because there are many more hits in the NSW than there are in the other stations, they need to be deweighted here so they don't dominate the truth matching.
The weight of 0.25 is chosen as there would be 24 hits expected in the NSW and 6 in one of the other stations.
This should help to resolve the issues with poor efficiency reported in ATLASRECTS-5610.

Removing const_casts from SimpleAmbiguityProcessorTool.

    
Don't use references in a range-for if the object must be copied.

Unused private data member.

Don't declare PutTrackCollectionsInSG as a component.
It's not needed, and duplicates one in TrkTrackCollectionMerger.

- remove `atlas_depends_on_subdirs`
- add library and use it in the component library and test executables
- fix library and external dependencies

- remove `atlas_depends_on_subdirs`
- fix link dependencies
- do not install component headers

Shaun Roe authored 4 years ago and Walter Lampl committed 4 years ago

change scoring interfaces to use TrackCollection, avoid additional copying of TrackCollection to vector

Goetz Gaycken authored 5 years ago and Walter Lampl committed 5 years ago

- Use a PRD-to-track map rather than the PRD_AssociationTool which conains a PRD-to-track map
  internally. This is needed to resolve ATLASRECTS-5005.
- Made all methods const.
- The score processor does not create track copies anymore, thus PRD-to-track maps stay valid for
  scored tracks.
- The ambiguity processors now use a helper class which manages the new and original tracks i.e.
  tracks with mixed ownership, and creates track copies only for the final track collection if
  necessary.
- Moved debug ntuple code of simple ambiguity processor to a new derived class, to improve the
  readability.

The PRDtoTrackMap has to be forwarded to the track summary helper. Therefore
extended interfaces are introduced for the track summary and summary helper
tool which allow to pass an optional PRDtoTrackMap through.