Merging upstream/master in order to have ClusteringAnalog and new jobsub functionality

(changed bin edges to int +- 0.5 and fixed error in bin indexing (skip 0th underfill bin)

Removed the possibility to define sensor with either (1 column, n rows) or (n columns, 1 row) and set the definition to (n cloumns, 1 row)

Removed empty vector being pushed to clipboard and added debug message if event time outside of time cuts

- When no datafile is given an InvalidValueError will be thrown instead of just logging an error
- Replaced '/n' by std::endl
- Datafile will now be used to calculate pedestal when pedestal file is not given

(The code removed was theoretically functioning, but did not provide any functionality and will be implemented in another way)
Removed code parts:
- Beginnig of cross talk correction
- Ability to load gainfile

	modified:   src/modules/EventLoaderALiBaVa/ALiBaVa/AsciiRoot.cpp
	modified:   src/modules/EventLoaderALiBaVa/ALiBaVa/DataFileRoot.cpp
	modified:   src/modules/EventLoaderALiBaVa/ALiBaVa/DataFileRoot.h
	modified:   src/modules/EventLoaderALiBaVa/EventLoaderALiBaVa.cpp

- Deleted commented code to increase readability

	modified:   src/modules/EventLoaderALiBaVa/ALiBaVa/DataFileRoot.cpp
	modified:   src/modules/EventLoaderALiBaVa/ALiBaVa/HDFRoot.cpp
	modified:   src/modules/EventLoaderALiBaVa/CMakeLists.txt

- Removed HDF5 compiler flag, as currently HDF5 is always required

Cleanup of EtaCalculation

See merge request corryvreckan/corryvreckan!566

Fix Issue in Module Instantiation

See merge request corryvreckan/corryvreckan!565

ClusteringAnalog module

See merge request corryvreckan/corryvreckan!552

and load it only when necessary.

Fabian Simon Lex authored 2 years ago and Simon Spannagel committed 2 years ago

Added timestamps to ALiBaVaEventloader events in order for later modules (Prealignment, etc) to work properly