Skip to content
Snippets Groups Projects
Forked from atlas / athena
Source project has a limited visibility.
  • Scott Snyder's avatar
    416749bf
    RootUtils: Fix py38 memory corruption. · 416749bf
    Scott Snyder authored and Adam Edward Barton's avatar Adam Edward Barton committed
    With python 3.8, the hacks used in pythonize_read_root_file lead to heap
    corruption.  Rework to avoid this.
    
    We're rather constrained since this has to work with both py2 and 3,
    so the way it's done here is a bit roundabout and ineffecient.
    Once we drop py2, this can be done much better by simply
    having read_root_file return a PyBytes object
    416749bf
    History
    RootUtils: Fix py38 memory corruption.
    Scott Snyder authored and Adam Edward Barton's avatar Adam Edward Barton committed
    With python 3.8, the hacks used in pythonize_read_root_file lead to heap
    corruption.  Rework to avoid this.
    
    We're rather constrained since this has to work with both py2 and 3,
    so the way it's done here is a bit roundabout and ineffecient.
    Once we drop py2, this can be done much better by simply
    having read_root_file return a PyBytes object
Code owners
Assign users and groups as approvers for specific file changes. Learn more.