Fix dependency of CaloBadChanTool (ATLASRECTS-4635)

TileBadChanTool tools was not declared as property
of CaloBadChanTool and it's dependencies was not propagated
up to CaloBadChanTool. This caused problems in AthenaMT
because this dependency was not propated to the algorithms
which use CaloBadChanTool. Now TileBadChanTool is declared
as property of CaloBadChanTool and made private.
The same is done also for LArBadChanTool because anyway
it should be made private at some moment.

Calorimeter/CaloBadChannelTool/CaloBadChannelTool/CaloBadChanTool.h

@@ -28,8 +28,8 @@ public:
 
 private:
 
-  ToolHandle<ICaloBadChanTool> m_larBCT;
-  ToolHandle<ICaloBadChanTool> m_tileBCT;
+  ToolHandle<ICaloBadChanTool> m_larBCT{this, "LArBadChanTool", "LArBadChanTool", "LAr bad channel tool"};
+  ToolHandle<ICaloBadChanTool> m_tileBCT{this, "TileBadChanTool", "TileBadChanTool", "Tile bad channel tool"};
   const CaloCell_ID* m_caloID;
 };
 

Calorimeter/CaloBadChannelTool/src/CaloBadChanTool.cxx

@@ -10,8 +10,6 @@
 CaloBadChanTool::CaloBadChanTool(const std::string& type, const std::string& name, 
 				 const IInterface* parent) :
   AthAlgTool( type, name, parent),
-  m_larBCT("LArBadChanTool"),
-  m_tileBCT("TileBadChanTool"),
   m_caloID(nullptr)
 {
   declareInterface<ICaloBadChanTool>(this);